Remove qiskit-bot notification rule for rust changes (backport #13198) #13201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and `@kevinhartman` as the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry. (cherry picked from commit 597f2b2)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
type: qa
ElePT
approved these changes
Sep 20, 2024
Pull Request Test Coverage Report for Build 10960512499Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and
@kevinhartmanas the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry.Details and comments
This is an automatic backport of pull request #13198 done by Mergify.